How should we combine CalculationType possible values with SystemCalculator possible methods ?

Question

Hi,

I'm calculating product systems' impacts in Java, using directly the olca-core maven module. As far as I know, this should be done like this :

```
ProductSystem system = ...
CalculationSetup setup = new CalculationSetup(CalculationType.SIMPLE_CALCULATION, system);
setup.impactMethod = ...
SystemCalculator calc = new SystemCalculator(mCache, new DenseSolver());
SimpleResult r = calc.calculateSimple(setup);

```

But, instead of SIMPLE_CALCULATION, I could have used CONTRIBUTION_ANALYSIS or UPSTREAM_ANALYSIS.
Moreover, instead of calculateSimple(), I could have used calculateContributions() or calculateUpstream().

Then, I'm wondering whether the three values of CalculationType can be combined with the three methods of the calculator, or whether SIMPLE_CALCULATION should go with calculateSimple(), and so on. I guess it's the case, but I'm not sure.

Thank you very much in advance for an answer,
Best,

Clement

Comments

Ok, I just saw this commit : https://github.com/GreenDelta/olca-modules/commit/d2151fa639a00c2d15010f827235a2082a370248#diff-529c9354f39c00ffc4b66129ffa607ea

Then I guess the answer is you are not supposed to combine as you want the calculation type and the calculation method...

But I'm still wondering about the "authorized" combinations.

---

Hi,
I hope you will see this but I really would appreciate if you could help me with my question, we are stuck while we don't know how to config the calculation properly.